refactor: Use icelake catalog api to simplify things. #12303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
requested review from
tabVersion,
BugenZhao,
ZENOTME and
wenym1
Codecov Report
@@ Coverage Diff @@
## main #12303 +/- ##
=======================================
Coverage 69.67% 69.68%
=======================================
Files 1422 1422
Lines 235791 235786 -5
=======================================
+ Hits 164294 164296 +2
+ Misses 71497 71490 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wenym1
reviewed
Sep 14, 2023
tabVersion
reviewed
Sep 14, 2023
|
Any other comments cc @tabVersion @wenym1 |
|
cc @neverchanje |
liurenjie1024
force-pushed
the
renjie/issue-12221
branch
from
e83c877 to
81d4958
Compare
liurenjie1024
force-pushed
the
renjie/issue-12221
branch
from
81d4958 to
0e15117
Compare
|
Per offline discussion, we removed breaking changes to keep the current syntax. cc @neverchanje @tabVersion @wenym1 |
wenym1
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Close #12221.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.